Open
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
vcjana
force-pushed
the
fix-dense-collection-null-handling
branch
from
a189021 to
9815deb
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Feb 24, 2026
Contributor
ysaito1001
left a comment
ysaito1001
left a comment
There was a problem hiding this comment.
Thank you for the fix. Didn't realize that rejection logic for "null in dense" has existed for server SDK.
| FailingTest.RequestTest(REST_XML, "HttpEmptyPrefixHeadersRequestClient"), | ||
| FailingTest.RequestTest(REST_JSON, "RestJsonHttpEmptyPrefixHeadersRequestClient"), | ||
| // Smithy protocol tests expect null to be silently dropped, but we now correctly reject it. | ||
| // These tests will be removed in https://github.com/smithy-lang/smithy/pull/2972 |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SDK now correctly throws an error when encountering null values in non-sparse (dense) collections during deserialization, instead of silently dropping them.
Changes
Related